Speed based color #1249
Merged
Speed based color #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tananaev
reviewed
Jun 26, 2024
| @@ -4,7 +4,7 @@ import { useSelector } from 'react-redux'; | |||
| import { map } from './core/MapView'; | |||
| import { getSpeedColor } from '../common/util/colors'; | |||
|
|
|||
| const MapRoutePath = ({ name, positions, coordinates }) => { | |||
There was a problem hiding this comment.
Why are we removing coordinates here?
There was a problem hiding this comment.
it's not being used anymore
There was a problem hiding this comment.
@jcardus Looks like this is not true. You broke combined report. I appreciate contributions, but please make sure you do proper due diligence before sending pull requests.
tananaev
reviewed
Jun 26, 2024
src/map/MapRoutePath.js
Outdated
Comment on lines
99
to
100
| map.getSource(id) | ||
| ?.setData({ |
There was a problem hiding this comment.
probably intellij automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1248