Replace Select with Autocomplete with single Selects #1212
Conversation
|
So I reworked the option label, changed some more code to use SelectField. |
|
Any chance that this gets merged? Or what would need to be done to get it merged? |
|
Is it ready for review? |
|
I was under the impression that all of the review questions were addressed - I just synced and fixed (the new?) linting. |
| <MenuItem key={keyGetter(item)} value={keyGetter(item)}>{titleGetter(item)}</MenuItem> | ||
| ))} | ||
| </Select> | ||
| {multiple ? ( |
There was a problem hiding this comment.
I think overall looks good. But I forgot now why are we not using Autocomplete for multi-select? It seems like it would be the most valuable there actually.
There was a problem hiding this comment.
Yes I agree, but I did not find an easy way to make it work/look 'properly' - that's why I split it up in two and first implemented single select.
The problem is that the MUI Autocomplete component when using multiple values 'adds' another row in the Input field and that does not look that good - see this comment for the image: #1189 (comment)
The idea was to move the actual 'search input' into the drop down list instead of growing the original input to 2 lines (so the original input would only contain selected values), like select2 does for example - but I did not find a sane/easy way of doing that at the time. So the decision was made to first do it for single select, get that merged so it makes my life easier with my big lists, then tackle the multi usecase later.
|
OK, let's merge this for now. Thanks |
As described in #1189 (comment) this is a new PR where I'm working on replacing all the single Select(s) with Autocomplete.
Currently in draft mode, as I'm not particularly happy how the SelectField change is implemented and I probably missed some Select(s)