Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camper device category #1195

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

TheZoker
Copy link
Contributor

This PR adds a new device category called Camper.

Screenshot of a tracker with that category:
image

Copy link
Member

@tananaev tananaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. What is the source of the image?
  2. Please don't include string translations. You should only include English.

@TheZoker TheZoker force-pushed the add-camper-category branch from 459c1c1 to 47be9a2 Compare November 23, 2023 14:29
@TheZoker
Copy link
Contributor Author

TheZoker commented Nov 23, 2023

The source is here:
https://www.iconpacks.net/free-icon/camper-van-13375.html

It is not required credit the author:
image

I removed the translations

@tananaev
Copy link
Member

Can you please provide a screen shot of the map with another category next to is, so we can compare.

@TheZoker
Copy link
Contributor Author

Here are three in a row:

image

@tananaev
Copy link
Member

It doesn't look very consistent with the style. Some very small details. And wheels are in different style.

@TheZoker
Copy link
Contributor Author

Alright I will look for a different file. Where do the original icons come from? Maybe that will help to find something.

It needs to be a icon without credit, right?

@tananaev
Copy link
Member

Yes, it needs to be without credit. I believe the original icons are from Icons8.

@TheZoker
Copy link
Contributor Author

Alright so this should be the car file:
https://icons8.de/icon/set/car/material-rounded

And this would be the camper:
https://icons8.de/icon/set/camper/material-rounded

Would that work for you?

@tananaev
Copy link
Member

I don't think those are links to specific image.

@TheZoker
Copy link
Contributor Author

@tananaev
Copy link
Member

Yeah, looks good to me.

@TheZoker
Copy link
Contributor Author

Here is the new preview:

image

Next to the camper I also added a caravan.

@tananaev
Copy link
Member

Wait. Are we adding two icons now? I think that's a bit of overkill.

@TheZoker
Copy link
Contributor Author

A friend that also uses the software for his caravan/trailer asked me if I can add this icon as well. But I can also remove it again

@tananaev
Copy link
Member

I think one icon is enough.

@TheZoker TheZoker force-pushed the add-camper-category branch from 6fa0f6b to 6515beb Compare November 24, 2023 00:21
@TheZoker
Copy link
Contributor Author

Done, second icon is removed again

@tananaev tananaev merged commit a1dce94 into traccar:master Nov 24, 2023
1 check passed
@tananaev
Copy link
Member

Merged, thanks.

@TheZoker TheZoker deleted the add-camper-category branch November 24, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants