-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add camper device category #1195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What is the source of the image?
- Please don't include string translations. You should only include English.
459c1c1
to
47be9a2
Compare
The source is here: It is not required credit the author: I removed the translations |
Can you please provide a screen shot of the map with another category next to is, so we can compare. |
It doesn't look very consistent with the style. Some very small details. And wheels are in different style. |
Alright I will look for a different file. Where do the original icons come from? Maybe that will help to find something. It needs to be a icon without credit, right? |
Yes, it needs to be without credit. I believe the original icons are from Icons8. |
Alright so this should be the car file: And this would be the camper: Would that work for you? |
I don't think those are links to specific image. |
Ah sorry, here is the correct link: |
Yeah, looks good to me. |
Wait. Are we adding two icons now? I think that's a bit of overkill. |
A friend that also uses the software for his caravan/trailer asked me if I can add this icon as well. But I can also remove it again |
I think one icon is enough. |
6fa0f6b
to
6515beb
Compare
Done, second icon is removed again |
Merged, thanks. |
This PR adds a new device category called
Camper
.Screenshot of a tracker with that category: