Update ReplayPage.jsx

setLoading in a try>finally rather than referencing multiple times
traccar · Dec 27, 2024 · 712de60 · 712de60
1 parent 5e0d235
commit 712de60
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/src/other/ReplayPage.jsx b/src/other/ReplayPage.jsx
@@ -137,20 +137,22 @@ const ReplayPage = () => {
     setFrom(from);
     setTo(to);
     const query = new URLSearchParams({ deviceId, from, to });
-    const response = await fetch(`/api/positions?${query.toString()}`);
-    if (response.ok) {
-      setIndex(0);
-      const positions = await response.json();
-      setPositions(positions);
-      setLoading(false);
-      if (positions.length) {
-        setExpanded(false);
+    try {
+      const response = await fetch(`/api/positions?${query.toString()}`);
+      if (response.ok) {
+        setIndex(0);
+        const positions = await response.json();
+        setPositions(positions);
+        if (positions.length) {
+          setExpanded(false);
+        } else {
+          throw Error(t('sharedNoData'));
+        }
       } else {
-        throw Error(t('sharedNoData'));
+        throw Error(await response.text());
       }
-    } else {
+    } finally {
       setLoading(false);
-      throw Error(await response.text());
     }
   });