Fix "'winheight' cannot be smaller than 'minwinheight'" #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2017 10:21
#4 When the following lines used for auto-resizing horizonal splits are in a user's .vimrc set winheight=5 set winminheight=5 set winheight=999 the above error happens because "set winheight=1 winwidth=1" appears in the Session.vim file for each window and thus tries to set winheight smaller than winminheight. This commit removes all instances of "set winheight=1 winwidth=1" from the Session.vim file so winheight is no longer set smaller than winminheight.
|
My solution seems to have stopped working at some point, so I'm going to close this PR. As of now I'm using the solution outlined here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4.
I attempted to write a good commit message. Let me know if I should change anything.
More importantly, is this a suitable fix? My (limited) testing showed this working without issues, but for all I know there could be instances where doing the filter wouldn't be a good idea. Thoughts?