Gstro/update dependencies #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 10, 2018 10:47
- Heimdallr updated their master branch (currently at specified commit) which drops their dependency on outdated libraries. But they have not made a new release for this change -- see issue here: trivago/Heimdallr.swift#118 - This prevents conflicts for Carthage users where they are using updated versions of those libraries. - The podspec file cannot be updated in the same way, but it may not be an issue. - Once Heimdallr has bumped their release, we can return to proper dependency versioning.
m4dc4p
approved these changes
May 10, 2018
ericmann
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Cartfile to point to Heimdallr commit
which drops their dependency on outdated libraries. But they have not
made a new release for this change -- see issue here:
New release based on master? trivago/Heimdallr.swift#118
updated versions of those libraries.
an issue for CocoaPods users.
dependency versioning.