Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.0.0 release #130

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

V1.0.0 release #130

wants to merge 10 commits into from

Conversation

toystars
Copy link
Owner

No description provided.

@AugustoAleGon
Copy link
Collaborator

Great refactor. Do you need some help here?

@toystars
Copy link
Owner Author

@AugustoAleGon definitely. But that would be after the refactor. I'll be adding some more comments in here. The plan as stated earlier in #31 is to reduce the number of props significantly, make styling configurable and also fix the most pressing issues.

During this refactor, some of the features would be removed until we figure out how best to re-add them back without having such a huge number of props. Below is the current type definition:

export interface MultiSelectProps {
    items: MultiSelectItem[];
    selectedItems: string[];
    onSelectedItemsChange: (selectedItems: string[]) => void;
    onAddItem?: (newItems: MultiSelectItem[]) => void;
    isSingleSelection?: boolean;
    hideSubmitButton?: boolean
    hideTags?: boolean;
}

It will most likely change before I wrap up the refactor in a couple of days.

I will make a list of all features removed during the refactor and we can split those up.

@AugustoAleGon
Copy link
Collaborator

@toystars awesome looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants