Fix for tox4 regression issue with setenv file and substitutions (#2435) #3521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
requested changes
Apr 29, 2025
| if not self._is_file_line(sub_line): | ||
| sub_raw.__setitem__(*self._extract_key_value(sub_line)) | ||
| else: | ||
| for k, v in self._stream_env_file(self._parse_file_line(sub_line), args): |
There was a problem hiding this comment.
No single letter variables outside of comprehensions.
| while self._needs_replacement: | ||
| line = self._needs_replacement.pop(0) | ||
| expanded_line = self._replacer(line, ConfigLoadArgs([], self._name, self._env_name)) | ||
| sub_raw = dict(self._extract_key_value(sub_line) for sub_line in expanded_line.splitlines() if sub_line) | ||
| expanded_line = self._replacer(line, args) |
There was a problem hiding this comment.
Can you explain the change here and why you done it this way?
There was a problem hiding this comment.
- [+] wrote descriptive pull request text
This part you didn't really address. Writing a descriptive text involves the approach you've taken and why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fix for the issue #2435. (#2435 (comment))
Please, make sure you address all the checklists (for details on how see
development documentation)! -->
tox -e fix)docs/changelogfolder