soft: evict a non-regular lock file without reading it#597
Merged
Conversation
0a1f282 to
946fd37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_read_lock_file reads the soft lock file straight after opening it, without first checking it is a regular file. A same-uid peer can plant a fifo at the lock path with a writer attached, so the non-blocking read raises EAGAIN, which stale detection's suppress() quietly swallows; the file is then never broken and acquire just wedges until timeout (an empty non-blocking fifo read also raises EAGAIN on FreeBSD even without a writer). This mirrors the guard added to the soft read/write marker in #588: fstat first, and when the path is not a regular file report it as a malformed lock with its mtime and inode so the usual age-based eviction clears it rather than reading from it.