Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/2] Remove some unnecessary MIRI-specific hacks #39

Closed
wants to merge 2 commits into from

Conversation

ProfFan
Copy link

@ProfFan ProfFan commented May 8, 2024

Tested locally with current nightly

@ProfFan ProfFan closed this May 8, 2024
@tower120
Copy link
Owner

tower120 commented May 8, 2024

I updated CI and fixed cross stable/nightly warnings.

You tried to replace this:

    for i in 0..count {
        *dst.add(i) = *src.add(i);
    }

With this :

ptr::copy(src, dst, count);

Did you benchmark the result? That was done as optimization, because manually copy loop was significantly faster then ptr::copy in my benchmarks in previous compiler versions. I wonder if that was "fixed".

@tower120
Copy link
Owner

tower120 commented May 8, 2024

I just did benchmarks. Unfortunately ptr::copy is still very slow on copying small values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants