-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix unit tests #54
Conversation
tome unit tests is not working for aarch64.
@zph I think #52 is a python issue with the aarch64-based platforms - bash works fine. I'm running into an issue with cross and macOS-aarch64 though - do you have any suggestions?
I took the github workflow file from one of your branches. |
This is encouraging! I can keep digging on my side too.
thanks for writing it! If you're able to send a PR as part of fixing #9, I'd love to see it in the repo! |
cross GH action documents lack of support for unit tests on darwin aarch64.
actually it looks like the action doesn't support tests in darwin aarch64 at all: https://github.com/houseabsolute/actions-rust-cross?tab=readme-ov-file#input-parameters. So I'll just skip it for now and merge this fix in? |
Sounds good 👍 |
really interesting! the action looks like it just delegate to another action, which in turn just install toolchains with the string directly. So I wonder if this is upstream all the way to rust toolchains? I'm logging off for now, but I'll at least merge this incremental improvement in. |
tome unit tests is not working for aarch64.