Send friendly messages if cant acquire counteragent #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Migrate to updated APIs
2. Capture acquire ca errors differently:
- 409 errors as expected ones as simple messages
- the left ones as exceptions
nkiryanov
deleted the
send-friendly-messages-if-cant-acquire-counteragent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Основное изменение: отправляем в sentry не исключения, а сообщения когда не можем добавить приглашение контрагнету с ошибкой в diadoc 409. Нужно чтоб было понятно, что это не ошибки, а ожидаемое поведение.
Решить по нормальному (проверять перед отправкой приглашения можем ли ему отправить) пока не могу — вроде у диадок есть API методы для этого, но они возвращают ошибочные данные. Возможно это я что-то пропустил в их API и хорошо бы узнать у поддержки, но к ней обратиться можно только за оч много $.
Дополнительно: у диадок обновился API, переехал с устаревших методов на новые.