Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App review #4

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

App review #4

wants to merge 7 commits into from

Commits on Feb 23, 2020

  1. Reviewing the repository and Carol App sampels. 

    Removed old projects, added new projects following the newest documentation: https://docs.carol.ai/docs/carol-app-dev
    Robson Poffo authored and Robson Poffo committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    5865916 View commit details
    Browse the repository at this point in the history

  2. Updating pycarol version, avoiding latest.

    Robson Poffo authored and Robson Poffo committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    7f7deb0 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Batch: updating to use the most recent docker definition. 

    Online: removing not needed tags.
    Robson Poffo authored and Robson Poffo committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    daaf4cb View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Adjusting the sequence of commands 

    Rui's comments:

RUN pip install -r requirements.txt should be before the ADD batch_carolapp/ /app/batch_carolapp/
then if you edit the app files, we dont need to rebuild all the image, just update this.

source: #4 (comment)
    @poffo
    poffo authored Mar 25, 2020
    Configuration menu
    Copy the full SHA
    ba79ed2 View commit details
    Browse the repository at this point in the history

  2. File not needed. Build docker image in Carol. 

    #4 (comment)
    @poffo
    poffo authored Mar 25, 2020
    Configuration menu
    Copy the full SHA
    e05806d View commit details
    Browse the repository at this point in the history

  3. Updating pycarol to use a fixed version 

    I am assuming the same version available when I updated the repo.
    @poffo
    poffo authored Mar 25, 2020
    Configuration menu
    Copy the full SHA
    a48ca86 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2020

  1. Removing dependency on Dockerfile to pycarol image 

    Removing the dependency and keeping the pycarol dependency on python side.
    @poffo
    poffo authored Apr 4, 2020
    Configuration menu
    Copy the full SHA
    ac3594b View commit details
    Browse the repository at this point in the history