fix(react): prevent rendering fallback if not shouldCatch error #1410
+85
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8c6c22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
People can be co-author:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -9 B (-0.01%) Total Size: 68.9 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1410 +/- ##
==========================================
- Coverage 73.89% 73.85% -0.05%
==========================================
Files 70 70
Lines 590 589 -1
Branches 131 131
==========================================
- Hits 436 435 -1
Misses 142 142
Partials 12 12
|
Co-authored-by: lucas0530 <[email protected]> Co-authored-by: HYUNGU KANG <[email protected]>
manudeli
force-pushed
the
react/fix/prevent-render-fallback-if-not-shouldCatch-error
branch
from
43647c6 to
5501676
Compare
|
@gwansikk @kangju2000 Check this PR together please. this is important fix in my opinion |
gwansikk
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
I agree with this change. If shouldCatch is false, I believe the fallback itself should not be executed.
In my opinion, the fallback of an ErrorBoundary is meant to act as a substitute for an error. Therefore, if error capturing has not occurred through shouldCatch, the ErrorBoundary should not treat it as an error, and the fallback itself should not be executed.
manudeli
deleted the
react/fix/prevent-render-fallback-if-not-shouldCatch-error
branch
manudeli
added a commit
that referenced
this pull request
Jan 13, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/[email protected] ### Patch Changes - [#1410](#1410) [`ce3cb11`](ce3cb11) Thanks [@manudeli](https://github.com/manudeli)! - fix(react): prevent rendering fallback if not shouldCatch error ## @suspensive/[email protected] ### Patch Changes - Updated dependencies \[[`ce3cb11`](ce3cb11)]: - @suspensive/[email protected] - @suspensive/[email protected] - @suspensive/[email protected] ## @suspensive/[email protected] ### Patch Changes - Updated dependencies \[[`ce3cb11`](ce3cb11)]: - @suspensive/[email protected] ## @suspensive/[email protected] ### Patch Changes - Updated dependencies \[[`ce3cb11`](ce3cb11)]: - @suspensive/[email protected] ## @suspensive/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issued by @LineGu @lucas0530
Prevent rendering fallback if not shouldCatch error
fallback should be exposed only when error is catched by ErrorBoundary
But in this case fallback was rendered and
console.log("child ErrorBoundary's fallback")was excuted. so we fixed itPR Checklist