use enum_from_bits
#311
Merged
use enum_from_bits
#311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rolls our Mycelium Git deps to hawkw/mycelium@13d0722
There's a comment in the TWI driver on a sui generis "generate `FromBits` for enums" macro saying "this should be in the `mycelium-bitfield` crate". It is now in that crate, so we should just use that.
hawkw
force-pushed
the
eliza/enum-try-from
branch
from
d5a0f20 to
27b5981
Compare
hawkw
added a commit
that referenced
this pull request
Apr 9, 2024
This rolls our Mycelium Git deps to hawkw/mycelium@13d0722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a comment in the TWI driver on a sui generis "generate
FromBitsfor enums" macro saying "this should be in themycelium-bitfieldcrate". It is now in that crate, so we shouldjust use that.