Skip to content

tricky-pipe improvements #91

tricky-pipe improvements

tricky-pipe improvements #91

Triggered via pull request November 29, 2023 20:10
Status Success
Total duration 9m 32s
Artifacts

CI.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

27 warnings
cargo fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just docs
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just clippy: source/plugtail/src/lib.rs#L29
warning: unsafe function's docs miss `# Safety` section --> source/plugtail/src/lib.rs:29:5 | 29 | unsafe fn unleak(p: *const ()) -> Self; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
just clippy: source/plugtail/src/lib.rs#L29
warning: unsafe function's docs miss `# Safety` section --> source/plugtail/src/lib.rs:29:5 | 29 | unsafe fn unleak(p: *const ()) -> Self; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
just clippy: source/calliope/src/client.rs#L45
warning: unused variable: `storage` --> source/calliope/src/client.rs:45:9 | 45 | storage: &'static StaticChannels<S, CAPACITY>, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_storage` | = note: `#[warn(unused_variables)]` on by default
just clippy: source/calliope/src/client.rs#L38
warning: fields `s2c` and `c2s` are never read --> source/calliope/src/client.rs:39:5 | 38 | pub struct StaticChannels<S: Service, const CAPACITY: usize> { | -------------- fields in this struct 39 | s2c: mpsc::StaticTrickyPipe<S::ServerMsg, CAPACITY>, | ^^^ 40 | c2s: mpsc::StaticTrickyPipe<S::ClientMsg, CAPACITY>, | ^^^ | = note: `#[warn(dead_code)]` on by default
just clippy: source/calliope/src/client.rs#L39
warning: fields `s2c` and `c2s` are never read --> source/calliope/src/client.rs:39:5 | 38 | pub struct StaticChannels<S: Service, const CAPACITY: usize> { | -------------- fields in this struct 39 | s2c: mpsc::StaticTrickyPipe<S::ServerMsg, CAPACITY>, | ^^^ 40 | c2s: mpsc::StaticTrickyPipe<S::ClientMsg, CAPACITY>, | ^^^ | = note: `#[warn(dead_code)]` on by default
just clippy: source/calliope/src/client.rs#L40
warning: fields `s2c` and `c2s` are never read --> source/calliope/src/client.rs:39:5 | 38 | pub struct StaticChannels<S: Service, const CAPACITY: usize> { | -------------- fields in this struct 39 | s2c: mpsc::StaticTrickyPipe<S::ServerMsg, CAPACITY>, | ^^^ 40 | c2s: mpsc::StaticTrickyPipe<S::ClientMsg, CAPACITY>, | ^^^ | = note: `#[warn(dead_code)]` on by default
just clippy: source/calliope/src/lib.rs#L65
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/calliope/src/lib.rs:65:5 | 65 | async fn send(&mut self, f: OutboundFrame<'_>) -> Result<(), Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` = note: `#[warn(async_fn_in_trait)]` on by default help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 65 - async fn send(&mut self, f: OutboundFrame<'_>) -> Result<(), Self::Error>; 65 + fn send(&mut self, f: OutboundFrame<'_>) -> impl std::future::Future<Output = Result<(), Self::Error>> + Send; |
just clippy: source/calliope/src/lib.rs#L68
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/calliope/src/lib.rs:68:5 | 68 | async fn recv(&mut self) -> Result<Self::RecvFrame, Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 68 - async fn recv(&mut self) -> Result<Self::RecvFrame, Self::Error>; 68 + fn recv(&mut self) -> impl std::future::Future<Output = Result<Self::RecvFrame, Self::Error>> + Send; |
just clippy: source/calliope/src/service.rs#L19
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/calliope/src/service.rs:19:5 | 19 | async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi<Reset>, Rejection>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 19 - async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi<Reset>, Rejection>; 19 + fn connect(&self, identity: Identity, hello: &[u8]) -> impl std::future::Future<Output = Result<SerBiDi<Reset>, Rejection>> + Send; |
just clippy: source/calliope/src/tests/mod.rs#L13
warning: unused import: `future::Future` --> source/calliope/src/tests/mod.rs:13:5 | 13 | future::Future, | ^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
just check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just check: source/calliope/src/client.rs#L45
warning: unused variable: `storage` --> source/calliope/src/client.rs:45:9 | 45 | storage: &'static StaticChannels<S, CAPACITY>, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_storage` | = note: `#[warn(unused_variables)]` on by default
just check: source/calliope/src/client.rs#L38
warning: fields `s2c` and `c2s` are never read --> source/calliope/src/client.rs:39:5 | 38 | pub struct StaticChannels<S: Service, const CAPACITY: usize> { | -------------- fields in this struct 39 | s2c: mpsc::StaticTrickyPipe<S::ServerMsg, CAPACITY>, | ^^^ 40 | c2s: mpsc::StaticTrickyPipe<S::ClientMsg, CAPACITY>, | ^^^ | = note: `#[warn(dead_code)]` on by default
just check: source/calliope/src/client.rs#L39
warning: fields `s2c` and `c2s` are never read --> source/calliope/src/client.rs:39:5 | 38 | pub struct StaticChannels<S: Service, const CAPACITY: usize> { | -------------- fields in this struct 39 | s2c: mpsc::StaticTrickyPipe<S::ServerMsg, CAPACITY>, | ^^^ 40 | c2s: mpsc::StaticTrickyPipe<S::ClientMsg, CAPACITY>, | ^^^ | = note: `#[warn(dead_code)]` on by default
just check: source/calliope/src/client.rs#L40
warning: fields `s2c` and `c2s` are never read --> source/calliope/src/client.rs:39:5 | 38 | pub struct StaticChannels<S: Service, const CAPACITY: usize> { | -------------- fields in this struct 39 | s2c: mpsc::StaticTrickyPipe<S::ServerMsg, CAPACITY>, | ^^^ 40 | c2s: mpsc::StaticTrickyPipe<S::ClientMsg, CAPACITY>, | ^^^ | = note: `#[warn(dead_code)]` on by default
just check: source/calliope/src/lib.rs#L65
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/calliope/src/lib.rs:65:5 | 65 | async fn send(&mut self, f: OutboundFrame<'_>) -> Result<(), Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` = note: `#[warn(async_fn_in_trait)]` on by default help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 65 - async fn send(&mut self, f: OutboundFrame<'_>) -> Result<(), Self::Error>; 65 + fn send(&mut self, f: OutboundFrame<'_>) -> impl std::future::Future<Output = Result<(), Self::Error>> + Send; |
just check: source/calliope/src/lib.rs#L68
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/calliope/src/lib.rs:68:5 | 68 | async fn recv(&mut self) -> Result<Self::RecvFrame, Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 68 - async fn recv(&mut self) -> Result<Self::RecvFrame, Self::Error>; 68 + fn recv(&mut self) -> impl std::future::Future<Output = Result<Self::RecvFrame, Self::Error>> + Send; |
just check: source/calliope/src/service.rs#L19
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/calliope/src/service.rs:19:5 | 19 | async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi<Reset>, Rejection>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 19 - async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi<Reset>, Rejection>; 19 + fn connect(&self, identity: Identity, hello: &[u8]) -> impl std::future::Future<Output = Result<SerBiDi<Reset>, Rejection>> + Send; |
just check: source/calliope/src/tests/mod.rs#L13
warning: unused import: `future::Future` --> source/calliope/src/tests/mod.rs:13:5 | 13 | future::Future, | ^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
just check: source/calliope/src/client.rs#L45
warning: unused variable: `storage` --> source/calliope/src/client.rs:45:9 | 45 | storage: &'static StaticChannels<S, CAPACITY>, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_storage` | = note: `#[warn(unused_variables)]` on by default
just check: source/calliope/src/client.rs#L38
warning: fields `s2c` and `c2s` are never read --> source/calliope/src/client.rs:39:5 | 38 | pub struct StaticChannels<S: Service, const CAPACITY: usize> { | -------------- fields in this struct 39 | s2c: mpsc::StaticTrickyPipe<S::ServerMsg, CAPACITY>, | ^^^ 40 | c2s: mpsc::StaticTrickyPipe<S::ClientMsg, CAPACITY>, | ^^^ | = note: `#[warn(dead_code)]` on by default
just test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just loom
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just miri
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/