Skip to content

feat(mgnp): add handshaking, redo outbound frame API #50

feat(mgnp): add handshaking, redo outbound frame API

feat(mgnp): add handshaking, redo outbound frame API #50

Triggered via pull request November 8, 2023 19:02
Status Failure
Total duration 7m 50s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

CI.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 27 warnings
just test
Process completed with exit code 101.
just miri
Process completed with exit code 100.
cargo fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just docs
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just clippy: source/tricky-pipe/src/oneshot.rs#L307
warning: you should consider adding a `Default` implementation for `Receiver<T>` --> source/tricky-pipe/src/oneshot.rs:307:5 | 307 | / pub fn new() -> Self { 308 | | Self::from_arc(Arc::new(Oneshot { 309 | | head: Header { 310 | | state: AtomicU8::new(HAS_RX), ... | 314 | | })) 315 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 303 + impl<T> Default for Receiver<T> { 304 + fn default() -> Self { 305 + Self::new() 306 + } 307 + } |
just clippy: source/tricky-pipe/src/oneshot.rs#L307
warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` --> source/tricky-pipe/src/oneshot.rs:307:5 | 307 | pub fn new() -> Self { | ^^^^^^^^^^^^^^^^^^^^ | = help: either add some descriptive text or remove the attribute = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use = note: `#[warn(clippy::double_must_use)]` on by default
just clippy: source/tricky-pipe/src/oneshot.rs#L239
warning: type does not implement `core::fmt::Debug`; consider adding `#[derive(Debug)]` or a manual implementation --> source/tricky-pipe/src/oneshot.rs:239:1 | 239 | / pub struct Oneshot<T> { 240 | | head: Header, 241 | | cell: UnsafeCell<MaybeUninit<T>>, 242 | | } | |_^ | note: the lint level is defined here --> source/tricky-pipe/src/oneshot.rs:86:9 | 86 | #![warn(missing_debug_implementations)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
just clippy: source/tricky-pipe/src/oneshot.rs#L239
warning: missing documentation for a struct --> source/tricky-pipe/src/oneshot.rs:239:1 | 239 | pub struct Oneshot<T> { | ^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> source/tricky-pipe/src/lib.rs:12:9 | 12 | #![warn(missing_docs)] | ^^^^^^^^^^^^
just clippy: source/tricky-pipe/src/oneshot.rs#L270
warning: missing documentation for an associated function --> source/tricky-pipe/src/oneshot.rs:270:5 | 270 | pub const fn new() -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^
just clippy: source/tricky-pipe/src/oneshot.rs#L280
warning: missing documentation for a method --> source/tricky-pipe/src/oneshot.rs:280:5 | 280 | pub fn static_receiver(&'static self) -> Option<Receiver<T>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
just clippy: source/tricky-pipe/src/oneshot.rs#L294
warning: missing documentation for a method --> source/tricky-pipe/src/oneshot.rs:294:5 | 294 | pub fn arc_receiver(self: Arc<Self>) -> Option<Receiver<T>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
just clippy: source/mgnp/src/lib.rs#L1
warning: the feature `async_fn_in_trait` has been stable since 1.75.0-nightly and no longer requires an attribute to enable --> source/mgnp/src/lib.rs:1:12 | 1 | #![feature(async_fn_in_trait)] | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(stable_features)]` on by default
just clippy: source/mgnp/src/connector.rs#L42
warning: unused variable: `storage` --> source/mgnp/src/connector.rs:42:9 | 42 | storage: &'static StaticChannels<S, CAPACITY>, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_storage` | = note: `#[warn(unused_variables)]` on by default
just clippy: source/mgnp/src/connector.rs#L35
warning: fields `s2c` and `c2s` are never read --> source/mgnp/src/connector.rs:36:5 | 35 | pub struct StaticChannels<S: registry::Service, const CAPACITY: usize> { | -------------- fields in this struct 36 | s2c: mpsc::StaticTrickyPipe<S::ServerMsg, CAPACITY>, | ^^^ 37 | c2s: mpsc::StaticTrickyPipe<S::ClientMsg, CAPACITY>, | ^^^ | = note: `#[warn(dead_code)]` on by default
just check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just check: source/tricky-pipe/src/oneshot.rs#L239
warning: type does not implement `Debug`; consider adding `#[derive(Debug)]` or a manual implementation --> source/tricky-pipe/src/oneshot.rs:239:1 | 239 | / pub struct Oneshot<T> { 240 | | head: Header, 241 | | cell: UnsafeCell<MaybeUninit<T>>, 242 | | } | |_^ | note: the lint level is defined here --> source/tricky-pipe/src/oneshot.rs:86:9 | 86 | #![warn(missing_debug_implementations)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
just check: source/tricky-pipe/src/oneshot.rs#L239
warning: missing documentation for a struct --> source/tricky-pipe/src/oneshot.rs:239:1 | 239 | pub struct Oneshot<T> { | ^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> source/tricky-pipe/src/lib.rs:12:9 | 12 | #![warn(missing_docs)] | ^^^^^^^^^^^^
just check: source/tricky-pipe/src/oneshot.rs#L270
warning: missing documentation for an associated function --> source/tricky-pipe/src/oneshot.rs:270:5 | 270 | pub const fn new() -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^
just check: source/tricky-pipe/src/oneshot.rs#L280
warning: missing documentation for a method --> source/tricky-pipe/src/oneshot.rs:280:5 | 280 | pub fn static_receiver(&'static self) -> Option<Receiver<T>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
just check: source/tricky-pipe/src/oneshot.rs#L294
warning: missing documentation for a method --> source/tricky-pipe/src/oneshot.rs:294:5 | 294 | pub fn arc_receiver(self: Arc<Self>) -> Option<Receiver<T>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
just check: source/mgnp/src/lib.rs#L1
warning: the feature `async_fn_in_trait` has been stable since 1.75.0-nightly and no longer requires an attribute to enable --> source/mgnp/src/lib.rs:1:12 | 1 | #![feature(async_fn_in_trait)] | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(stable_features)]` on by default
just check: source/mgnp/src/connector.rs#L42
warning: unused variable: `storage` --> source/mgnp/src/connector.rs:42:9 | 42 | storage: &'static StaticChannels<S, CAPACITY>, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_storage` | = note: `#[warn(unused_variables)]` on by default
just check: source/mgnp/src/connector.rs#L35
warning: fields `s2c` and `c2s` are never read --> source/mgnp/src/connector.rs:36:5 | 35 | pub struct StaticChannels<S: registry::Service, const CAPACITY: usize> { | -------------- fields in this struct 36 | s2c: mpsc::StaticTrickyPipe<S::ServerMsg, CAPACITY>, | ^^^ 37 | c2s: mpsc::StaticTrickyPipe<S::ClientMsg, CAPACITY>, | ^^^ | = note: `#[warn(dead_code)]` on by default
just check: source/mgnp/src/connector.rs#L36
warning: fields `s2c` and `c2s` are never read --> source/mgnp/src/connector.rs:36:5 | 35 | pub struct StaticChannels<S: registry::Service, const CAPACITY: usize> { | -------------- fields in this struct 36 | s2c: mpsc::StaticTrickyPipe<S::ServerMsg, CAPACITY>, | ^^^ 37 | c2s: mpsc::StaticTrickyPipe<S::ClientMsg, CAPACITY>, | ^^^ | = note: `#[warn(dead_code)]` on by default
just check: source/mgnp/src/connector.rs#L37
warning: fields `s2c` and `c2s` are never read --> source/mgnp/src/connector.rs:36:5 | 35 | pub struct StaticChannels<S: registry::Service, const CAPACITY: usize> { | -------------- fields in this struct 36 | s2c: mpsc::StaticTrickyPipe<S::ServerMsg, CAPACITY>, | ^^^ 37 | c2s: mpsc::StaticTrickyPipe<S::ClientMsg, CAPACITY>, | ^^^ | = note: `#[warn(dead_code)]` on by default
just test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just loom
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just miri
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/