Skip to content

feat(mgnp): initial MGNP protocol implementation (#2) #30

feat(mgnp): initial MGNP protocol implementation (#2)

feat(mgnp): initial MGNP protocol implementation (#2) #30

Triggered via push November 1, 2023 16:59
Status Success
Total duration 5m 9s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

CI.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

24 warnings
cargo fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just clippy: source/mgnp-pitch/src/lib.rs#L1
warning: the feature `async_fn_in_trait` has been stable since 1.75.0-nightly and no longer requires an attribute to enable --> source/mgnp-pitch/src/lib.rs:1:12 | 1 | #![feature(async_fn_in_trait)] | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(stable_features)]` on by default
just clippy: source/plugtail/src/lib.rs#L29
warning: unsafe function's docs miss `# Safety` section --> source/plugtail/src/lib.rs:29:5 | 29 | unsafe fn unleak(p: *const ()) -> Self; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
just clippy: source/plugtail/src/lib.rs#L29
warning: unsafe function's docs miss `# Safety` section --> source/plugtail/src/lib.rs:29:5 | 29 | unsafe fn unleak(p: *const ()) -> Self; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
just clippy: source/mgnp-pitch/src/lib.rs#L33
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/lib.rs:33:5 | 33 | async fn send(&mut self, f: OutboundMessage<'_>) -> Result<(), Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` = note: `#[warn(async_fn_in_trait)]` on by default help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 33 - async fn send(&mut self, f: OutboundMessage<'_>) -> Result<(), Self::Error>; 33 + fn send(&mut self, f: OutboundMessage<'_>) -> impl std::future::Future<Output = Result<(), Self::Error>> + Send; |
just clippy: source/mgnp-pitch/src/lib.rs#L34
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/lib.rs:34:5 | 34 | async fn recv(&mut self) -> Result<Self::Frame, Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 34 - async fn recv(&mut self) -> Result<Self::Frame, Self::Error>; 34 + fn recv(&mut self) -> impl std::future::Future<Output = Result<Self::Frame, Self::Error>> + Send; |
just clippy: source/mgnp-pitch/src/registry.rs#L18
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/registry.rs:18:5 | 18 | async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi, Nak>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 18 - async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi, Nak>; 18 + fn connect(&self, identity: Identity, hello: &[u8]) -> impl std::future::Future<Output = Result<SerBiDi, Nak>> + Send; |
just clippy: source/mgnp-pitch/src/lib.rs#L1
warning: the feature `async_fn_in_trait` has been stable since 1.75.0-nightly and no longer requires an attribute to enable --> source/mgnp-pitch/src/lib.rs:1:12 | 1 | #![feature(async_fn_in_trait)] | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(stable_features)]` on by default
just clippy: source/mgnp-pitch/src/lib.rs#L33
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/lib.rs:33:5 | 33 | async fn send(&mut self, f: OutboundMessage<'_>) -> Result<(), Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` = note: `#[warn(async_fn_in_trait)]` on by default help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 33 - async fn send(&mut self, f: OutboundMessage<'_>) -> Result<(), Self::Error>; 33 + fn send(&mut self, f: OutboundMessage<'_>) -> impl std::future::Future<Output = Result<(), Self::Error>> + Send; |
just clippy: source/mgnp-pitch/src/lib.rs#L34
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/lib.rs:34:5 | 34 | async fn recv(&mut self) -> Result<Self::Frame, Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 34 - async fn recv(&mut self) -> Result<Self::Frame, Self::Error>; 34 + fn recv(&mut self) -> impl std::future::Future<Output = Result<Self::Frame, Self::Error>> + Send; |
just clippy: source/mgnp-pitch/src/registry.rs#L18
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/registry.rs:18:5 | 18 | async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi, Nak>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 18 - async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi, Nak>; 18 + fn connect(&self, identity: Identity, hello: &[u8]) -> impl std::future::Future<Output = Result<SerBiDi, Nak>> + Send; |
just docs
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just check: source/mgnp-pitch/src/lib.rs#L1
warning: the feature `async_fn_in_trait` has been stable since 1.75.0-nightly and no longer requires an attribute to enable --> source/mgnp-pitch/src/lib.rs:1:12 | 1 | #![feature(async_fn_in_trait)] | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(stable_features)]` on by default
just check: source/mgnp-pitch/src/lib.rs#L33
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/lib.rs:33:5 | 33 | async fn send(&mut self, f: OutboundMessage<'_>) -> Result<(), Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` = note: `#[warn(async_fn_in_trait)]` on by default help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 33 - async fn send(&mut self, f: OutboundMessage<'_>) -> Result<(), Self::Error>; 33 + fn send(&mut self, f: OutboundMessage<'_>) -> impl std::future::Future<Output = Result<(), Self::Error>> + Send; |
just check: source/mgnp-pitch/src/lib.rs#L34
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/lib.rs:34:5 | 34 | async fn recv(&mut self) -> Result<Self::Frame, Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 34 - async fn recv(&mut self) -> Result<Self::Frame, Self::Error>; 34 + fn recv(&mut self) -> impl std::future::Future<Output = Result<Self::Frame, Self::Error>> + Send; |
just check: source/mgnp-pitch/src/registry.rs#L18
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/registry.rs:18:5 | 18 | async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi, Nak>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 18 - async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi, Nak>; 18 + fn connect(&self, identity: Identity, hello: &[u8]) -> impl std::future::Future<Output = Result<SerBiDi, Nak>> + Send; |
just check: source/mgnp-pitch/src/lib.rs#L1
warning: the feature `async_fn_in_trait` has been stable since 1.75.0-nightly and no longer requires an attribute to enable --> source/mgnp-pitch/src/lib.rs:1:12 | 1 | #![feature(async_fn_in_trait)] | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(stable_features)]` on by default
just check: source/mgnp-pitch/src/lib.rs#L33
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/lib.rs:33:5 | 33 | async fn send(&mut self, f: OutboundMessage<'_>) -> Result<(), Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` = note: `#[warn(async_fn_in_trait)]` on by default help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 33 - async fn send(&mut self, f: OutboundMessage<'_>) -> Result<(), Self::Error>; 33 + fn send(&mut self, f: OutboundMessage<'_>) -> impl std::future::Future<Output = Result<(), Self::Error>> + Send; |
just check: source/mgnp-pitch/src/lib.rs#L34
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/lib.rs:34:5 | 34 | async fn recv(&mut self) -> Result<Self::Frame, Self::Error>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 34 - async fn recv(&mut self) -> Result<Self::Frame, Self::Error>; 34 + fn recv(&mut self) -> impl std::future::Future<Output = Result<Self::Frame, Self::Error>> + Send; |
just check: source/mgnp-pitch/src/registry.rs#L18
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> source/mgnp-pitch/src/registry.rs:18:5 | 18 | async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi, Nak>; | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 18 - async fn connect(&self, identity: Identity, hello: &[u8]) -> Result<SerBiDi, Nak>; 18 + fn connect(&self, identity: Identity, hello: &[u8]) -> impl std::future::Future<Output = Result<SerBiDi, Nak>> + Send; |
just test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
just loom
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/