Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): limit tortoise-orm version to >=0.21 instead of wildcard (*) #388

Merged
merged 7 commits into from
Dec 21, 2024

Conversation

waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Dec 12, 2024

Closes #228

After try this:

make deps
pip install --upgrade "tortoise-orm<0.21"
# pip install --upgrade "tortoise-orm<0.20"
# pip install --upgrade "tortoise-orm<0.19"
# pip install --upgrade "tortoise-orm<0.18"
make test_postgres && make test_mysql && make test_sqlite && echo done.

Got ERROR:

...
======================================== 1 failed, 17 passed in 1.01s ========================================
make: *** [test_postgres] Error 1

So I limit the tortoise-orm version to '>=0.21'
and then run unittests for different torotise versions in ci.

CHANGELOG.md Outdated Show resolved Hide resolved
tortoise-orm:
- tortoise021
- tortoise022
- tortoisedev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@waketzheng waketzheng merged commit 1acb9ed into tortoise:dev Dec 21, 2024
18 checks passed
@waketzheng waketzheng deleted the limit-tortoise-verison branch December 21, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid wildcard (*) dependency to tortoise-orm
2 participants