Skip to content

Add exporter up metric #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add exporter up metric #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97001ad
Add exporter up metric
avachette Aug 22, 2024
f73784a
Update test with the new metric
avachette Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions strongswan/collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ type viciClientFn func() (ViciClient, error)
type Collector struct {
viciClientFn viciClientFn

up *prometheus.Desc
ikeCnt *prometheus.Desc
ikeVersion *prometheus.Desc
ikeStatus *prometheus.Desc
Expand Down Expand Up @@ -62,6 +63,11 @@ func NewCollector(viciClientFn viciClientFn) *Collector {
return &Collector{
viciClientFn: viciClientFn,

up: prometheus.NewDesc(
prefix+"up",
"Whether scraping metrics was successful.",
nil, nil,
),
ikeCnt: prometheus.NewDesc(
prefix+"ike_count",
"Number of known IKEs",
Expand Down Expand Up @@ -202,6 +208,7 @@ func NewCollector(viciClientFn viciClientFn) *Collector {
}

func (c *Collector) Describe(ch chan<- *prometheus.Desc) {
ch <- c.up
ch <- c.ikeCnt
ch <- c.ikeVersion
ch <- c.ikeStatus
Expand Down Expand Up @@ -240,13 +247,23 @@ func (c *Collector) Collect(ch chan<- prometheus.Metric) {
prometheus.GaugeValue,
float64(0),
)
ch <- prometheus.MustNewConstMetric(
c.up,
prometheus.GaugeValue,
float64(0),
)
return
}
ch <- prometheus.MustNewConstMetric(
c.ikeCnt,
prometheus.GaugeValue,
float64(len(sas)),
)
ch <- prometheus.MustNewConstMetric(
c.up,
prometheus.GaugeValue,
float64(1),
)
for _, ikeSa := range sas {
c.collectIkeMetrics(ikeSa, ch)
for _, child := range ikeSa.Children {
Expand Down
19 changes: 19 additions & 0 deletions strongswan/collector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,25 @@ func TestCollector_Metrics(t *testing.T) {
wantMetricsValue int
wantMetricsCount int
}{
{
name: "Strongswan status without IKEs",
metricName: "strongswan_up",
wantMetricsHelp: "Whether scraping metrics was successful.",
wantMetricsType: "gauge",
wantMetricsValue: 0,
wantMetricsCount: 1,
},
{
name: "Strongswan status with IKEs",
msgsModifierFn: func(msgs *vici.Message) {
msgs.Set("ike-name", vici.NewMessage())
},
metricName: "strongswan_up",
wantMetricsHelp: "Whether scraping metrics was successful.",
wantMetricsType: "gauge",
wantMetricsValue: 1,
wantMetricsCount: 1,
},
{
name: "connection error",
viciClientErr: errors.New("some error"),
Expand Down