Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-24 Add CTA fields (text+link) to footer #362

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

bmispelon
Copy link
Collaborator

Link to Ticket

Description of Changes Made

Added two new global navigation settings: footer_newsletter_cta_url and footer_newsletter_cta_text which are used in the footer component instead of the placeholder link and text.

How to Test

  1. Go to Navigation settings
  2. Populate the footer newsletter CTA link & text fields (all the way at the bottom) and save
  3. Go to any live page and scroll to the bottom
  4. The footer newsletter CTA should use the link & text from step 2

Screenshots

Expand to see more ![Screenshot 2025-02-10 at 10-22-30 Torchbox Digital Agency - Charity Nonprofit Education Sectors](https://github.com/user-attachments/assets/1f90f9cd-afbd-445e-b2f4-a176e93a268e)

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Firefox on Linux
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

Copy link
Collaborator

@SharmaineLim SharmaineLim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Baptiste!

Btw, your screenshot didn't quite make it into the description. :)

@bmispelon bmispelon merged commit cb42c86 into integration/2024-evolution Feb 11, 2025
4 checks passed
@bmispelon bmispelon deleted the feature/twe-24-footer-CTA branch February 11, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants