Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-16 | FE | Optional intro and buttons #343

Open
wants to merge 2 commits into
base: feature/twe-16-optional-intro
Choose a base branch
from

Conversation

albinazs
Copy link
Collaborator

@albinazs albinazs commented Jan 16, 2025

Link to Ticket

Description of Changes Made

Update styles for the Work Chooser and Blog Chooser blocks:

  • Style new optional intro and buttons
  • Make small changes to spacings
  • Keep the "listing tail" / arrow (discuss with Ben E.)
  • Fine-tune letter-spacing global styles for headings (discussed with Ben E.)
  • Add missing spacing values to the Tailwind config: spacerSmallPlus and spacerMediumPlus. They don't seem to work locally after restarting the server and re-building assets, which could be a glitch.

Buttons-related BE changes

How to Test

Check the components in the DPL:
http://0.0.0.0:8000/pattern-library/render-pattern/patterns/molecules/streamfield/blocks/blog_chooser_block.html
http://0.0.0.0:8000/pattern-library/render-pattern/patterns/molecules/streamfield/blocks/work_chooser_block.html

Screenshots

Expand to see more

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@albinazs albinazs self-assigned this Jan 16, 2025
@albinazs albinazs requested a review from chris-lawton January 16, 2025 13:47
Copy link
Member

@chris-lawton chris-lawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @albinazs - both components look good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants