scripts: flash_script.sh: Check the MAGISKBIN variable before constructing the environment #8425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cting the environment If the MAGISKBIN variable is not configured, or is configured with an empty string, the installation script will become a script that formats the device. No one wants to accept such an outcome. Even though our previous code was very rigorous, such an important check would not be redundant.
|
It can't happen Magisk/scripts/util_functions.sh Line 742 in 5e6b53e |
I would avoid writing |
-rm -rf $MAGISKBIN/* 2>/dev/null
+rm -rf $MAGISKBIN 2>/dev/nullDo you mean this? Sure, update your PR. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the MAGISKBIN variable is not configured, or is configured with an empty string, the installation script will become a script that formats the device. No one wants to accept such an outcome.
Even though our previous code was very rigorous, such an important check would not be redundant.