Skip to content

Commit

Permalink
fix(*) hashHistory add parameter to avoid warning
Browse files Browse the repository at this point in the history
  • Loading branch information
topheman committed Nov 6, 2015
1 parent c20082d commit aa57b1d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/bootstrap.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ httpService.getInstance(httpServiceConfiguration);//will keep config in singleto
//this way, instead of using resolve.alias of webpack (and having the require of module messed up by webpack when they'll be executed server-side)
//I use dependency injection, in the one place that won't be executed in node : the client side bootstrap

const history = createHashHistory({queryKey:false});
const history = createHashHistory({queryKey:'hash'});
ReactDOM.render(<Router history={history}>{routes}</Router>, document.getElementById('app-container'))
1 change: 1 addition & 0 deletions src/components/Home.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const Home = () => (
<p>Please check out the <a href="https://github.com/topheman/react-es6" title="react-es6 on github">github repo</a> or read <a href="http://dev.topheman.com/playing-with-es6-and-react/" title="Playing with React and ES6">the original blog post</a> for further informations.</p>
<p><strong>TL;DR</strong> : click on the button to try it !</p>
<p className="text-center"><Link className="btn btn-default btn-primary btn-lg" to="/github">TRY the DAMN thing !</Link></p>
<small>Annoyed by the query parameter in the url ? Since this project is hosted on Github pages, I can't use .htaccess or server-side script to redirect all requests to <code>index.html</code>, so, it's a tradeoff, so that urls could be shared/reloaded.</small>
</div>
);

Expand Down

0 comments on commit aa57b1d

Please sign in to comment.