Add foundational support for loading p5 addons in preview-frame.ts. #63
Conversation
| } | ||
|
|
||
| let global = window as PreviewFrameWindow; | ||
|
|
||
| function loadP5(version: string, cb?: () => void) { | ||
| let url = '//cdnjs.cloudflare.com/ajax/libs/p5.js/' + version + '/p5.js'; | ||
| function loadScript(url, cb?: () => void) { |
There was a problem hiding this comment.
o hai :-) just a drive-by suggestion here: might be nice to listen for script load errors and log something to the console for debugging
There was a problem hiding this comment.
Ah good idea! I'll add that--this will also be useful for when we allow people to specify arbitrary URLs to third-party add-on libraries, since we want to provide good feedback if they misspell any of those URLs or something.
There was a problem hiding this comment.
Cool! Glad my drive-by review was helpful ^_^
On Monday, August 29, 2016, Atul Varma [email protected] wrote:
In lib/preview-frame.ts
#63 (comment):}
let global = window as PreviewFrameWindow;
-function loadP5(version: string, cb?: () => void) {
- let url = '//cdnjs.cloudflare.com/ajax/libs/p5.js/' + version + '/p5.js';
+function loadScript(url, cb?: () => void) {Ah good idea! I'll add that--this will also be useful for when we allow
people to specify arbitrary URLs to third-party add-on libraries, since we
want to provide good feedback if they misspell any of those URLs or
something.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/toolness/p5.js-widget/pull/63/files/ffe52963c21320e73664190dcfa70c2878b3a50e#r76695989,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF4jGGEq79d0FNqZtg7XCRb6v1kKU5tks5qk1ZqgaJpZM4Ju51N
.
|
@toolness Awesome! I'm still wrapping my head around the concept and syntax here, but I get that this lets us call p5 global mode after we're sure everything else has loaded. Seems more elegant than a bunch of iframes too. I'll stay tuned for the response to processing/p5.js#1570 :) |
This adds foundational support for loading multiple libraries which depend on p5.js in
preview-frame.ts. It effectively implements option 3 described in #53 (comment).The biggest volatility here is that it uses an undocumented feature of the
p5constructor whereby if asketchfunction isn't passed in as the first argument, p5 will initialize itself in global mode. If we can make this a documented, supported use case in p5 core, that will ensure the widget continues to work as p5 matures. I've filed processing/p5.js#1570 for this.Thoughts @kaganjd ?