Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tofu: refresh network name #485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tofu: refresh network name #485

wants to merge 1 commit into from

Conversation

aborrero
Copy link

The network has a new name.

Bug: T389942

The network has a new name.

Bug: T389942
Signed-off-by: Arturo Borrero Gonzalez <[email protected]>
@aborrero aborrero requested a review from supertassu March 26, 2025 10:23
Copy link
Member

@supertassu supertassu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check whether tofu lets this to be changed without re-creating things? this variable is directly fed to the openstack_containerinfra_clustertemplate_v1 resource (without being translated to an ID first)

also, fixed_subnet below is not changing, right?

@aborrero
Copy link
Author

did you check whether tofu lets this to be changed without re-creating things? this variable is directly fed to the openstack_containerinfra_clustertemplate_v1 resource (without being translated to an ID first)

The change is unlikely to require re-creating, as the ID of the network has not changed. The network name is usually a cosmetic thing. This did not require re-creation even in the tofu-infra repository.

In any case I have to say: I did not checked, and I don't plan to. Whoever wants to follow up merging this patch will need to double check.

also, fixed_subnet below is not changing, right?

Correct, this is not changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants