Skip to content

Update zfs-dkms.spec.in #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: fedora-kernel-conflict
Choose a base branch
from

Conversation

jkool702
Copy link

limits to "Requires" dependencies to kernel-devel-matched (which is basically kernel-core+kernel-devel). Adds "Conflicts" dependencies to cover all the rerst of the non-debug kernel subpackages.

tonyhutter and others added 3 commits April 24, 2025 13:27
A user reported that when your upgrade your kernel packages on Fedora
with ZFS installed, only the kernel-devel package gets held back to the
ZFS-supported version, but not the other kernel packages. So if ZFS only
supports the 6.13 kernel, Fedora will still happily upgrade the kernel
RPMs to 6.14, but hold back kernel-devel at 6.13, for example.

This commit includes version checks for the 'kernel', 'kernel-core' and
'kernel-modules-core' packages.

Closes: openzfs#17265

Original-patch-by: @jkool702
Signed-off-by: Tony Hutter <[email protected]>
limits to "Requires" dependencies to kernel-devel-matched (which is basically kernel-core+kernel-devel). Adds "Conflicts" dependencies to cover all the rerst of the non-debug kernel subpackages.
Signed-off-by: jkool702 <[email protected]>
@tonyhutter
Copy link
Owner

As long as ZFS doesn't have a dependency on a package, then the user should be able to install it. We should not artificially restrict all kernel-related packages for a particular kernel version just because ZFS doesn't support that kernel version. It's possible the user may want to install newer kernel-related packages for reasons unrelated to ZFS. For example, they may be running ZFS 2.3.0, but also want the kernel-docs-6.15 package to read the documentation for a newer kernel, for some reason.

Here's how I see it:

ZFS cares about these:

kernel
kernel-modules-core
kernel-modules

ZFS does not need this to build:

kernel-modules-extra

I think this is for kernel test cases - not needed:

kernel-modules-internal

Kernel-devel depends on kernel-headers, so kernel-headers is implied:

kernel-headers
kernel-cross-headers

We use the same spec file for both Fedora and RHEL, and RHEL 8 doesn't support:

kernel-devel-matched

ZFS technically doesn't have a dependency on these, so we should allow them:

kernel-uki-virt-addons (I don't think ZFS
kernel-tools-libs-devel
kernel-selftests-internal
kernel-doc

Let me know if there is an actual dependency we need in here that I may have missed.

@tonyhutter tonyhutter force-pushed the fedora-kernel-conflict branch 4 times, most recently from 495bab1 to 8eff9d4 Compare April 29, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants