Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snow particles not pausing #690

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

LiteralGenie
Copy link

Fixes #689

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 18.45%. Comparing base (970c7e6) to head (98c6153).

Files with missing lines Patch % Lines
src/panel/effects/snow.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   18.46%   18.45%   -0.02%     
==========================================
  Files          31       31              
  Lines        1527     1528       +1     
  Branches      198      198              
==========================================
  Hits          282      282              
- Misses       1235     1240       +5     
+ Partials       10        6       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonybaloney tonybaloney self-requested a review February 8, 2025 04:34
@tonybaloney
Copy link
Owner

thanks!

@tonybaloney tonybaloney merged commit 66f1f13 into tonybaloney:main Feb 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snow effect not paused while window is minimized
3 participants