Remove the dependency on Python.NET #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Implement a managed string interop with Python Unicode objects
… and create safehandle for PyObject ptr
…into libraryimport
… thread that starts Python. Put this thread into a state object with a cancellation token so later we can do things with it.
… that was required.
… for the integration test.
…determine types. Support sub-types.
aaronpowell
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to enhance the testing and runtime capabilities of the project. The most significant changes involve the addition of new tests for various data type conversions, updates to the CI configuration, and the introduction of new functionality in the runtime code.
Testing Enhancements:
BoolConverterTest,DoubleConverterTest,DictionaryConverterTest,ListConverterTest,LongConverterTest,TupleConverterTests, andUnicodeConverterTestin thesrc/CSnakes.Runtime.Tests/Converterdirectory. These tests ensure that conversions between C# types and Python objects are accurate and bidirectional. [1] [2] [3] [4] [5] [6] [7]ConverterTestBaseclass to provide a common setup for the converter tests, including initializing the Python environment and configuring services.CI Configuration:
.github/workflows/dotnet-ci.ymlfile to includemacos-13in the OS matrix and setfail-fastto false to improve the robustness of the CI pipeline.Runtime Enhancements:
CPythonAPIclass to handle Python boolean and callable objects, includingPyBool_FromLong,IsPyBool,IsPyTrue, and variousPyObject_Callmethods for different argument scenarios. [1] [2]Project Setup:
CSnakes.Runtime.Tests.csprojfile to define the test project setup, including package references and project dependencies.launchSettings.jsonfile to the test project to enable native debugging.Load Testing:
loadtest.jmxfile to thesamples/WebAppdirectory to define a JMeter test plan for load testing the web application.Implements #70
Implements #3