Allow users to run Python code from a string #340
Conversation
| @@ -144,4 +145,34 @@ public bool IsDisposed() | |||
| { | |||
| return disposedValue; | |||
| } | |||
|
|
|||
| public PyObject Execute(string code) | |||
There was a problem hiding this comment.
The method does not handle potential exceptions that could be thrown by CPythonAPI.PyRun_String. Consider adding exception handling to catch and log errors.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| } | ||
| } | ||
|
|
||
| public PyObject Execute(string code, IDictionary<string, PyObject> locals) |
There was a problem hiding this comment.
The method does not handle potential exceptions that could be thrown by CPythonAPI.PyRun_String. Consider adding exception handling to catch and log errors.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| } | ||
| } | ||
|
|
||
| public PyObject Execute(string code, IDictionary<string, PyObject> globals, IDictionary<string, PyObject> locals) |
There was a problem hiding this comment.
The method does not handle potential exceptions that could be thrown by CPythonAPI.PyRun_String. Consider adding exception handling to catch and log errors.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
tonybaloney
changed the title
There was a problem hiding this comment.
While the code itself looks fine I question the general value of this, as what role is .NET really playing here? Like, you really need to know the inputs and outputs beforehand so that you can read/write them, or you just pass through arbitrary code with .NET not really "touching" anything at either end (which seems inherently dangerous)
|
This would be used for edge cases, like running complicated expressions on an object that you've got back from CSnakes, or dynamically running a bit of interpreted code on the module. |
|
Yeah, I read the issue so I "get" the use-case but it's the kind of thing I wonder if CSnakes is the best tool for, since .NET isn't exactly idea for a scripting environment. |
Implements #290
Adds two different types of API:
1+1) and returns the result