Add support for async functions #313
Conversation
tonybaloney
changed the title
|
Tests are hanging because |
|
|
||
| while (!initialized) // Wait for startup | ||
| { | ||
| continue; |
There was a problem hiding this comment.
I'm sure there's a better pattern for doing this, also we should maybe add a 50ms sleep here
There was a problem hiding this comment.
Perhaps TaskCompletionSource<T>?
There was a problem hiding this comment.
Could also use some event (for example, ManualResetEventSlim or AutoResetEvent) instead of a loop in the above initialization thread.
| // Clean-up interns | ||
| NewEventLoopFactory?.Dispose(); | ||
| AsyncioModule?.Dispose(); | ||
| // TODO: Add more cleanup code here |
There was a problem hiding this comment.
This TODO is to clean up the currently static globals which we never dispose of, but are cleaned up automatically. We should dispose of them incase people recycle environments.
|
|
||
| public EventLoop() | ||
| { | ||
| loop = NewEventLoopFactory!.Call(); |
There was a problem hiding this comment.
This call can return a null? If so, why not simply throw here if null?
| close?.Call(); | ||
| } | ||
|
|
||
| public void Dispose() |
There was a problem hiding this comment.
We should ensure that Dispose() can be called multiple times. Not sure if this implementation handles that.
| IsDisposed = true; | ||
| } | ||
|
|
||
| public PyObject RunTaskUntilComplete(PyObject coroutine) |
There was a problem hiding this comment.
Public APIs on a type that implement IDisposable typically throw an ObjectDisposedException when they are disposed.
|
|
||
| while (!initialized) // Wait for startup | ||
| { | ||
| continue; |
There was a problem hiding this comment.
Perhaps TaskCompletionSource<T>?
|
|
||
| while (!initialized) // Wait for startup | ||
| { | ||
| continue; |
There was a problem hiding this comment.
Could also use some event (for example, ManualResetEventSlim or AutoResetEvent) instead of a loop in the above initialization thread.
|
Hi @tonybaloney et. al, |
Concept:
Coroutine[T_Yield, T_Send, T_Return]will be mapped to anICoroutine<Tyield, TSend, TReturn>, similar to GeneratorAsTask()which returns aTask<TYield>by executing the following:The code generator has been updated to reflect the function to
Task<TYield>as moves theAsTask()execution outside of the initial GIL block to ensure they don't get deadlocked.