publishing to GitHub packages only after packaging job completes.

Done as a workflow_run trigger so that we can run in the right GITHUB_TOKEN context

.github/workflows/dotnet-publish-ci.yml

@@ -1,7 +1,7 @@
 # This workflow will build a .NET project
 # For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-net
 
-name: .NET Publish (GitHub Packages)
+name: .NET Publish (CI)
 
 on:
   pull_request:
@@ -16,11 +16,6 @@ env:
 jobs:
   publish-github-packages:
     runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      packages: write
-      attestations: write
-      id-token: write
     steps:
       - uses: actions/checkout@v4
       - name: Setup .NET
@@ -46,6 +41,3 @@ jobs:
         with:
           name: nuget-packages
           path: ./nuget
-
-      - name: Publish to GitHub packages
-        run: dotnet nuget push ./nuget/*.nupkg --source "https://nuget.pkg.github.com/tonybaloney/index.json" --api-key ${{ secrets.GITHUB_TOKEN }}

.github/workflows/dotnet-publish-gh-packages.yml

@@ -0,0 +1,19 @@
+name: "Publish NuGet packages to GitHub Packages"
+on:
+  workflow_run:
+    workflows: [".NET Publish (CI)"]
+    types:
+      - completed
+jobs:
+  report:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      packages: write
+      attestations: write
+      id-token: write
+    steps:
+      - uses: actions/download-artifact@v4
+        with:
+          name: nuget-packages
+          run-id: ${{ github.event.workflow_run.id }}

.github/workflows/dotnet-publish-main.yml

@@ -1,7 +1,7 @@
 # This workflow will build a .NET project
 # For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-net
 
-name: .NET Publish (NuGet)
+name: .NET Publish (main)
 
 on:
   push: