Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '--follow-imports silent' to mypy invocation #12

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

eliwe
Copy link
Contributor

@eliwe eliwe commented Aug 6, 2018

Else we get all the errors for all the imported files on the current file.

Else we get all the errors for all the imported files on the current file.
@tomv564
Copy link
Owner

tomv564 commented Aug 7, 2018

Sounds reasonable. I'm a bit worried that hardcoding this will prevent users making other choices for this setting in mypy.ini, but perhaps this is an unlikely problem?

There is a recent effort integrating support for the mypy daemon, which might replace this plugin altogether: palantir/python-language-server#392

@eliwe
Copy link
Contributor Author

eliwe commented Aug 7, 2018

Form what I can see the LSP server (and LSP protocol) expect to get back errors for the specified file only. There is no field to return in a different file.

@tomv564
Copy link
Owner

tomv564 commented Oct 29, 2018

Sorry for the slow response.
Key information for me was that this option doesn't reduce quality by replacing imports with Any.
Looking at the docs, this is what skip does, while silent strictly checks with imported types unless not found. Sounds ideal as a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants