Skip to content

Commit

Permalink
fix: correct build issues
Browse files Browse the repository at this point in the history
  • Loading branch information
maxflintoff-tomtom committed Jun 19, 2024
1 parent 86833fd commit b502b38
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/create-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_dispatch:
# push:
# branches:
# - main-enterprise
# - main-tomtom

env:
REGISTRY: ghcr.io
Expand All @@ -26,7 +26,7 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Log in to the Container registry
uses: docker/login-action@v3
uses: docker/login-action@v3
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
Expand All @@ -38,14 +38,14 @@ jobs:
file: ./Dockerfile
load: true
tags: |
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:main-enterprise
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:main-tomtom
- name: Inspect the Docker Image
run: |
docker image inspect ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:main-enterprise
docker image inspect ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:main-tomtom
- name: Run Functional Tests
id: functionaltest
run: |
docker run --env APP_ID=${{ secrets.APP_ID }} --env PRIVATE_KEY=${{ secrets.PRIVATE_KEY }} --env WEBHOOK_SECRET=${{ secrets.WEBHOOK_SECRET }} -d -p 3000:3000 ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:main-enterprise
docker run --env APP_ID=${{ secrets.APP_ID }} --env PRIVATE_KEY=${{ secrets.PRIVATE_KEY }} --env WEBHOOK_SECRET=${{ secrets.WEBHOOK_SECRET }} -d -p 3000:3000 ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:main-tomtom
sleep 10
curl http://localhost:3000
- name: Tag a final release
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ module.exports = (robot, { getRouter }, Settings = require('./lib/settings')) =>
}

async function info() {
const log = robot.log.child({ context: 'index', repository: repo.repo })
const log = robot.log.child({ context: 'index' })
const github = await robot.auth()
const installations = await github.paginate(
github.apps.listInstallations.endpoint.merge({ per_page: 100 })
Expand Down
1 change: 1 addition & 0 deletions lib/plugins/validator.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const NopCommand = require('../nopcommand')
const ErrorStash = require('./errorStash')
module.exports = class Validator extends ErrorStash {
constructor (nop, github, repo, settings, log) {
super([], log, repo.repo)
Expand Down

0 comments on commit b502b38

Please sign in to comment.