Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test against python 3.11, and run codecov in a non-deprecated way #250

Closed
wants to merge 2 commits into from

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Apr 13, 2023

More about the deprecation of codecov uploader in https://github.com/codecov/codecov-action.

@tomplus
Copy link
Owner

tomplus commented Apr 13, 2023

It hits #234

@consideRatio
Copy link
Contributor Author

consideRatio commented Apr 13, 2023

@tomplus yepp, I saw Martiusweb/asynctest#163 now, suggesting that asynctest is dropped:

I believe unittest.mock.AsyncMock in combination with pytest is probably your best bet for now.

Hmmm, I lack experience here.

Ah but also from that issue:

unittest.IsolatedAsyncioTestCase is basically a drop-in replacement

@consideRatio
Copy link
Contributor Author

consideRatio commented Apr 13, 2023

Hmmm, trialing a bit and looking at the souce code, I'm not confident on how to proceed overall. asynctest is used in quite a few places and I'm not savvy with patch mock etc.

Note that we have tests in jupyterhub/kubespawner running Python 3.11 and relying on this package, so it hasn't broken down entirely at least. I'm sadly not able to allocate time the next month or two to learn and finish this PR with a migration of asynctest.

Thank you soo much for your work on this project @tomplus, it has worked great for jupyterhub/kubespawner and is helping users across the world doing research and education among other things! If left unresolved I hope to find time to help out here!

@tomplus
Copy link
Owner

tomplus commented Apr 13, 2023

Thanks for your kind words and your contribution ❤️

Let's keep this PR opened, I'll fix the tests soon and then we'll merge it.

@tomplus
Copy link
Owner

tomplus commented Apr 19, 2023

@consideRatio Sorry, while I was fixing async tests, I had to upgrade codecov too. I completely forgot about your PR and I did the same job :/

@consideRatio
Copy link
Contributor Author

Ah no worries at all! Thank you for your work on this project!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants