Fix compilation for 32bit #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does not compile in GCC 11 either (64 bits) |
|
Ok, I see this merge in the develop branch |
|
Hi @Darky-Lucera sorry for extremely late reply but somehow I didn't get a notification on this issue. This commit is outdated. I just tried compiling libschrift for 32 bit and it works. It only gives a warning in stress.c because the glyph variable is declared as long unsigned int instead of SFT_Glyph (which would be the same on 64 bit, hence no warning) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmap_fmt4, cmap_fmt6 and glyph_id functions declaration and definition didn't match, causing errors when compiling for 32bit (-m32 compiler and linker flag). Some variables were created as unsigned long, pointer to them was passed to functions taking uint_fast_32_t* which is unsigned long int* (not the same as unsigned long*). I think the whole uint_fast_32_t can be replaced with just unsigned int, but I didn't do it in this PR.