-
Notifications
You must be signed in to change notification settings - Fork 2
[Snyk] Security upgrade starlette from 0.27.0 to 0.49.1 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ce vulnerabilities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-STARLETTE-13733964
Summary of ChangesHello @tomkat-cr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, addresses a security vulnerability by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk aims to upgrade the starlette package to version 0.49.1 to fix a security vulnerability. While the intention is good, the change as proposed is likely to break the build of the base-python-docker image. The requirements.txt for this image contains an unpinned fastapi dependency, which has strict version constraints on starlette. The new starlette version will conflict with the fastapi version that pip tries to install. I've left a comment with a detailed explanation and a recommendation to pin all dependencies in the file and upgrade fastapi and starlette together to resolve the conflict.
| supabase | ||
| python-dotenv | ||
| asyncpg | ||
| starlette>=0.49.1 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is likely to break the build for the Docker image.
The fastapi package, which is included in this requirements.txt, has a strict dependency on starlette. For example, the latest public version of fastapi (0.111.0) requires starlette < 0.38.0, which conflicts with the >=0.49.1 constraint being added. This will cause pip to fail during dependency resolution.
The root cause is that dependencies in this file are not pinned, which can lead to unpredictable behavior. The Snyk warning about pydantic in the PR description is another symptom of this.
To fix this properly, you should:
- Pin all dependencies in this file to specific versions for reproducible builds. You can use the versions from the root
requirements.txtas a starting point. - Upgrade
fastapito a version that is compatible withstarlette >= 0.49.1to resolve the security vulnerability without breaking the build. Bothfastapiandstarletteversions should be pinned.
Since this automated PR doesn't account for the fastapi dependency, it needs manual intervention to resolve the conflict.
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
gsam_ottomator_agent/base_python_docker/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)