Fix missing non-zero return code from TEE'd pipe #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wat Looks like linter is broken in CI, I've run nox locally, all checks passed. |
|
Yeah, I think it is. Will look at it when on a computer. |
|
Btw, nox is great. I did not know what it is, installed it, and it just worked from the first try, and ran all tests? Super cool |
|
See https://learn.scientific-python.org/development/guides/tasks/ - I love it. :) I see what's wrong - we've pinned an old pylint, and it doesn't support Python 3.12, which is what the default is now. I'm fixing that in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked that modified test is failing, and fix in this branch makes it green.
Fixes #660