Fix missing non-zero return code from TEE'd pipe

tomerfiliba · Oct 31, 2023 · c2ce578 · c2ce578
1 parent 40fcd27
commit c2ce578
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/plumbum/commands/modifiers.py b/plumbum/commands/modifiers.py
@@ -226,6 +226,7 @@ def __rand__(self, cmd):
 
                         buf.append(data)
 
+            p.wait()  # To get return code in p
             stdout = "".join([x.decode("utf-8") for x in outbuf])
             stderr = "".join([x.decode("utf-8") for x in errbuf])
             return p.returncode, stdout, stderr

diff --git a/tests/test_local.py b/tests/test_local.py
@@ -620,6 +620,8 @@ def test_modifiers(self):
         assert not (command_false & TF)
         assert command & RETCODE == 0
         assert command_false & RETCODE == 1
+        assert (command & TEE)[0] == 0
+        assert (command_false & TEE(retcode=None))[0] == 1
 
     @skip_on_windows
     def test_tee_modifier(self, capfd):