Skip to content

Commit

Permalink
Fixing CI (#444)
Browse files Browse the repository at this point in the history
* Fixing CI

* macOS Travis adds some text to the error

* Newer brew and cleanups

* Travis: trusty EOL, faster macOS Python 3

* Fix Py2.6

* Fixing py 2.6 again
  • Loading branch information
henryiii authored May 14, 2019
1 parent d86a7e0 commit 67bcf0f
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 9 deletions.
3 changes: 3 additions & 0 deletions .ci/travis.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@

echo $TRAVIS_PYTHON_VERSION

# Listed twice to workaround Python 2.6
if [[ "$(uname -s)" == 'Darwin' ]]; then
python$PY3 -m pip install --upgrade pip
python$PY3 -m pip install -r dev-requirements.txt
python$PY3 -m pip install coveralls
python$PY3 -m pip install -e .
else
pip install --upgrade pip
pip install -r dev-requirements.txt
pip install coveralls
pip install -e .
Expand Down
13 changes: 7 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
sudo: required
language: python
dist: trusty
dist: xenial
matrix:
include:
- python: 2.6
dist: trusty
env: PYV=2.6
before_install:
- pip install pycparser==2.17
Expand All @@ -17,20 +18,20 @@ matrix:
env: PYV=3.6
- python: 3.7
env: PYV=3.7
dist: xenial
# - python: nightly
- python: pypy
- language: generic
env: PY3=2 PYV=Mac2
os: osx
before_install:
- python2 -m ensurepip --upgrade
- python2 -m ensurepip
- language: generic
os: osx
env: PY3=3 PYV=Mac3
before_install:
- brew update || echo "Already updated"
- brew upgrade python@3 || echo "Python3 already installed"
addons:
homebrew:
packages:
- python

install: .ci/travis.sh
script: python$PY3 setup.py test -c
Expand Down
2 changes: 2 additions & 0 deletions dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,6 @@ idna<2.8 ; python_version < '2.7'
pycparser<2.18 ; python_version < '2.7'
paramiko<2.4 ; python_version < '2.7'
paramiko ; python_version >= '2.7'
setuptools
wheel ; python_version >= '2.7'
psutil
2 changes: 0 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ def run(self):
keywords = "path, local, remote, ssh, shell, pipe, popen, process, execution, color, cli",
cmdclass = {'test':PyTest,
'docs':PyDocs},
# use_2to3 = False,
# zip_safe = True,
long_description = open(os.path.join(HERE, "README.rst"), "r").read(),
classifiers = [
"Development Status :: 5 - Production/Stable",
Expand Down
2 changes: 1 addition & 1 deletion tests/test_remote.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ def test_iter_lines_error(self):
for i, lines in enumerate(rem["ls"]["--bla"].popen()):
pass
assert i == 1
assert ex.value.stderr.startswith("/bin/ls: ")
assert "/bin/ls: " in ex.value.stderr

def test_touch(self):
with self._connect() as rem:
Expand Down

0 comments on commit 67bcf0f

Please sign in to comment.