feat: accept path-like (pathlib.Path) objects (#627)

* .gitignore: add .idea * local: accept path-like (`pathlib.Path`) objects * chore: flake8 & ci fix Signed-off-by: Henry Schreiner <[email protected]> Signed-off-by: Henry Schreiner <[email protected]> Co-authored-by: Henry Schreiner <[email protected]>
tomerfiliba · Dec 13, 2022 · 0eb15d0 · 0eb15d0
1 parent a89f381
commit 0eb15d0
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -47,6 +47,11 @@ jobs:
           os: ubuntu-latest
         - python-version: 'pypy-3.9'
           os: ubuntu-latest
+        - python-version: '3.6'
+          os: ubuntu-20.04
+        exclude:
+        - python-version: '3.6'
+          os: ubuntu-latest
     runs-on: ${{ matrix.os }}
 
     steps:

diff --git a/.gitignore b/.gitignore
@@ -164,3 +164,6 @@ cython_debug/
 
 /tests/nohup.out
 /plumbum/version.py
+
+# jetbrains
+.idea
diff --git a/plumbum/machines/local.py b/plumbum/machines/local.py
@@ -233,6 +233,8 @@ def __getitem__(self, cmd):
             return LocalCommand(cmd)
 
         if not isinstance(cmd, RemotePath):
+            # handle "path-like" (pathlib.Path) objects
+            cmd = os.fspath(cmd)
             if "/" in cmd or "\\" in cmd:
                 # assume path
                 return LocalCommand(local.path(cmd))

diff --git a/setup.cfg b/setup.cfg
@@ -18,8 +18,8 @@ exclude_lines =
 
 [flake8]
 max-complexity = 50
-extend-ignore = E203, E501, B950, T202
-extend-select = B9
+extend-ignore = E203, E501, T202
+extend-select = B902, B903, B904
 per-file-ignores =
     tests/*: T
     examples/*: T

diff --git a/tests/test_local.py b/tests/test_local.py
@@ -3,6 +3,7 @@
 import signal
 import sys
 import time
+from pathlib import Path
 
 import pytest
 
@@ -329,6 +330,10 @@ def test_imports(self):
 
             assert non_exist1N9
 
+    def test_pathlib(self):
+        ls_path = Path(local.which("ls"))
+        assert "test_local.py" in local[ls_path]().splitlines()
+
     def test_get(self):
         assert str(local["ls"]) == str(local.get("ls"))
         assert str(local["ls"]) == str(local.get("non_exist1N9", "ls"))