Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

feat(lib): ignore js file #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darbychang
Copy link

No description provided.

@tomchentw
Copy link
Owner

Hmmm don't you feel weird to ignore certain file in a plugin? I don't think it's a good idea.

@darbychang
Copy link
Author

Well, it makes me can gulp.src() all js and ls files once without special processing (such as streamqueue or gulp-filter). I know there should be a better way. My code is a simple work around like gulp-stylus on .css files. Maybe you can check it?

@tomchentw
Copy link
Owner

Sure. Put them on here or a separate gist would be fine.
I do agree that in the ecosystem of gulp, we should keep each transform do one thing well. For the filtering task, as you said maybe applying gulp-filter or gulp-if would be a better idea.

@tomchentw tomchentw closed this Jun 7, 2015
@tomchentw tomchentw reopened this Jun 7, 2015
@tomchentw
Copy link
Owner

Sorry accidentally closed this. I'll leave it open for a while for further discussion

@darbychang
Copy link
Author

Sorry I forgot to attach them here. See https://github.com/stevelacy/gulp-stylus/blob/master/index.js#L24-L26 To me, it is not to do more than one thing. It is just a work around.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants