Only use distances of band #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for higher absolute invocations counts, which we're starting to need for crunching Everest-scale DEMs. The function that finds the dispatch sizes also tries to balance dispatches for better workgroup saturation?
And some moving of code into dedicated functions etc.
Previously we were using the distances of every single point in the DEM. But I realised that the distances are always the same for every band. This has yet another massive space saving, probably √N. The total surface area tests did change very slightly, I hope I didn't overlook anything. But we can't validate any actual correctness until I actually am able to reconstruct individual viewsheds.
tombh
force-pushed
the
only-use-distances-of-band
branch
from
915d010 to
53ba380
Compare
GeoTiff would be ideal, but Rust's current `geotiff` crate can't handle the size of DEMs that we need (to calculate the longest line of sight on the planet).
tombh
force-pushed
the
only-use-distances-of-band
branch
from
53ba380 to
cec4ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big space reduction. Like 5.5MB to 1.6KB for 1200x1200 DEMS! So ~3500x improvement.
Remember to
rm -r ~/.local/state/total-viewshedswhen updating to this PR.TODO: