Coltonbrugger master #389
Open
Coltonbrugger master #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayer property changes Resolves #336
When a layer was not fully instantiated (perhaps due to not being assigned "source" geojson yet), it is still listed as a layer to be destroyed, though the `olLayer` is undefined for it. This update avoids attempts to remove a layer that is undefined.
This change tries to infer the attribution given the source configuration of the ol3 object. Apparently each OL3 source type might have different properties for storing the attribution. Thus the code needs to iterate over them and "search" for the presence of it. WARNING: This also slightly changes the default behavior, meaning while currently the attribution had to be enabled explicitly you now have to opt-out by setting the `source.attribution = false`.
This addresses issue #386. It is a one-character change, changing the protocol from http to https.
BREAKING CHANGE: upgrade to openlayers 4 The upgrade to openlayers 4 might break some people.
Adjust the version number in order to create a breaking change with semantic-release plugin. BREAKING CHANGE: The upgrade to v4 of openlayers which happened in commit e7a0708 is a breaking change requiring a major version bump
|
Thx @coltonbrugger for PRing this, really appreciate and I'm sorry I didn't merge this earlier. But I didn't work on this project any more and a lot of other things happened meanwhile. As I took some time today for some cleanup, I came across your PR and rebased it with the latest changes which results in this PR here. Could you just give this a look whether this branch still works for you? As I don't have any project right now using angular-openlayers-directive which makes it a bit hard to verify 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #365.