Skip to content

Commit

Permalink
Wait until buffers are released in `ExceedingServiceMaxContentLengthT…
Browse files Browse the repository at this point in the history
…est.maxContentLength` (line#5600)

Motivation:

ref: https://github.com/line/armeria/actions/runs/8657061918/job/23738591838#step:11:1610
I believe the bytebuf release lifecycle doesn't have a causal relationship with receiving the response

<!--
Visit this URL to learn more about how to write a pull request description:
https://armeria.dev/community/developer-guide#how-to-write-pull-request-description
-->
  • Loading branch information
jrhee17 authored Apr 18, 2024
1 parent f43656e commit 3d800a2
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,6 @@ void maxContentLength(SessionProtocol protocol, String path) throws InterruptedE
await().untilAsserted(
() -> assertThat(responseCause.get()).isExactlyInstanceOf(ContentTooLargeException.class));

assertThat(byteBufs).allSatisfy(buf -> assertThat(buf.refCnt()).isZero());
await().untilAsserted(() -> assertThat(byteBufs).allSatisfy(buf -> assertThat(buf.refCnt()).isZero()));
}
}

0 comments on commit 3d800a2

Please sign in to comment.