Small fixes #98
Merged
Small fixes #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Thanks a lot for catching these bugs William! Added one suggestion to change from try-except to if-then. |
|
Thanks again @wbalmer 🙏! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tomas, these are a few very small bugs I found in running some retrievals this past month.
When plotting a free chemistry retrieval, there was no enumerator in the loop so the C/H, O/H, and C/O posteriors were returned with =0.
When global_fsed was set false, and then post processed to make plots, it would give a KeyError: "fsed", which I handled with the try/except statement (not sure if there is a different way you'd prefer to handle that).
The mmw wasn't established in the chemical equilibrium portion of the clear spectrum generator.