Adding unique_pair keyword to obs_nodding_irregular for Issue #11. #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for Issue #11 to deal with regular nodding sequences containing multiple exposures per nod.
obs_nodding_irregular
has received a new keywordunique_pairs
, which if set, will enforce a unique pairing between each A and B nod in a linear order.Consider the following AAAABBBB BBBBAAAA sequence of numbered A and B frames:
1A, 2A, 3A, 4A, 5B, 6B, 7B, 8B, 9B, 10B, 11B, 12B, 13A, 14A... etc.
With
unique_pairs=True
, the following nodding pairs will be passed to cr2res_obs_nodding:1A and 5B
2A and 6B
3A and 7B
4A and 8B
5B and 1A
6B and 2A
7B and 3A
8B and 4A
9B and 13A
10B and 14A
etc.
This is not the perfect solution for dealing with multiple exposures per nod (as discussed in Issue #11), but will work as a temporary fix and should generally be OK for time series where the background is not high compared to the target trace (K band and shorter). Also note that this invalidates half of the
cr2res_obs_nodding_combined
frames, and only thecr2res_obs_nodding_extracted
frames, or at most only the A or B variant of thecr2res_obs_nodding_combined
frames should be used.