WIP: DiffParser #95 #102
Closed
WIP: DiffParser #95 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasbjerre
force-pushed
the
feature/diff-parser
branch
from
b7aee2f
to
3197ccc
Compare
tomasbjerre
force-pushed
the
master
branch
3 times, most recently
from
760c34a
to
fd92797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress for #95 .
Not sure about how useful this actually is. Perhaps this can be a first step, and next step can be to enhence the
Violationmodel withsuggestedChange. So that comment-libraries can implement it.Was not able to find a good library for parsing unified diffs. The one I eventually tried does have some bugs, java-diff-utils/java-diff-utils#98 java-diff-utils/java-diff-utils#97. API is also strange, java-diff-utils/java-diff-utils#99.
Example
patch-files from Spotless or ErrorProne should be added to this PR.