-
Notifications
You must be signed in to change notification settings - Fork 39
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
513d19e
commit 582711c
Showing
7 changed files
with
155 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
src/main/java/se/bjurr/violations/lib/parsers/DiffParser.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| package se.bjurr.violations.lib.parsers; | ||
|
|
||
| import static java.nio.charset.StandardCharsets.UTF_8; | ||
| import static java.util.stream.Collectors.joining; | ||
| import static se.bjurr.violations.lib.model.Violation.violationBuilder; | ||
| import static se.bjurr.violations.lib.reports.Parser.DIFF; | ||
|
|
||
| import java.io.ByteArrayInputStream; | ||
| import java.io.InputStream; | ||
| import java.util.Set; | ||
| import java.util.TreeSet; | ||
|
|
||
| import com.github.difflib.patch.AbstractDelta; | ||
| import com.github.difflib.patch.ChangeDelta; | ||
| import com.github.difflib.patch.DeltaType; | ||
| import com.github.difflib.patch.Patch; | ||
| import com.github.difflib.unifieddiff.UnifiedDiff; | ||
| import com.github.difflib.unifieddiff.UnifiedDiffFile; | ||
| import com.github.difflib.unifieddiff.UnifiedDiffReader; | ||
|
|
||
| import se.bjurr.violations.lib.ViolationsLogger; | ||
| import se.bjurr.violations.lib.model.SEVERITY; | ||
| import se.bjurr.violations.lib.model.Violation; | ||
|
|
||
| public class DiffParser implements ViolationsParser { | ||
|
|
||
| @Override | ||
| public Set<Violation> parseReportOutput(String reportContent, ViolationsLogger violationsLogger) throws Exception { | ||
| Set<Violation> violations = new TreeSet<>(); | ||
| InputStream reportContentStream = new ByteArrayInputStream(reportContent.getBytes(UTF_8)); | ||
| UnifiedDiff parsedDiff = UnifiedDiffReader.parseUnifiedDiff(reportContentStream); | ||
| for(UnifiedDiffFile diffFile : parsedDiff.getFiles()) { | ||
| String file = diffFile.getFromFile(); | ||
| Patch<String> patch = diffFile.getPatch(); | ||
| for (AbstractDelta<?> delta : patch.getDeltas()) { | ||
| if (delta.getType() == DeltaType.CHANGE) { | ||
| @SuppressWarnings("unchecked") | ||
| ChangeDelta<String> changeDelta = (ChangeDelta<String>)delta; | ||
| String fromString = changeDelta.getSource().getLines().stream().collect(joining("\n")); | ||
| int fromLine = changeDelta.getSource().getPosition(); | ||
| String toString = changeDelta.getTarget().getLines().stream().collect(joining("\n")); | ||
| changeDelta.getTarget().getPosition(); | ||
|
|
||
| violations.add(violationBuilder() | ||
| .setParser(DIFF) | ||
| .setFile(file) | ||
| .setStartLine(fromLine) | ||
| .setMessage(fromString+"\n\nTo:\n\n"+toString) | ||
| .setSeverity(SEVERITY.ERROR) | ||
| .build()); | ||
| } | ||
| } | ||
| } | ||
| return violations; | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package se.bjurr.violations.lib; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static se.bjurr.violations.lib.TestUtils.getRootFolder; | ||
| import static se.bjurr.violations.lib.ViolationsApi.violationsApi; | ||
| import static se.bjurr.violations.lib.model.SEVERITY.INFO; | ||
| import static se.bjurr.violations.lib.reports.Parser.DIFF; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Set; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import se.bjurr.violations.lib.model.Violation; | ||
|
|
||
| public class DiffTest { | ||
|
|
||
| @Test | ||
| public void testThatGoVetViolationsCanBeParsed() { | ||
| final String rootFolder = getRootFolder(); | ||
|
|
||
| final Set<Violation> actual = | ||
| violationsApi() // | ||
| .withPattern(".*/diff/0001-.*") // | ||
| .inFolder(rootFolder) // | ||
| .findAll(DIFF) // | ||
| .violations(); | ||
|
|
||
| assertThat(actual) // | ||
| .hasSize(3); | ||
|
|
||
| Violation violation0 = new ArrayList<>(actual).get(0); | ||
| assertThat(violation0.getMessage()) // | ||
| .isEqualTo("this is a message"); | ||
| assertThat(violation0.getFile()) // | ||
| .isEqualTo("my_file.go"); | ||
| assertThat(violation0.getSeverity()) // | ||
| .isEqualTo(INFO); | ||
| assertThat(violation0.getStartLine()) // | ||
| .isEqualTo(46); | ||
| } | ||
| } |
41 changes: 41 additions & 0 deletions
41
src/test/resources/diff/0001-Gradle-Release-Plugin-new-version-commit-1.128-SNAPS.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| From 513d19e33d0a78b778bc2cd33551a300e7605975 Mon Sep 17 00:00:00 2001 | ||
| From: Tomas Bjerre <[email protected]> | ||
| Date: Sun, 6 Sep 2020 07:26:13 +0200 | ||
| Subject: [PATCH] [Gradle Release Plugin] - new version commit: | ||
| '1.128-SNAPSHOT'. | ||
|
|
||
| --- | ||
| CHANGELOG.md | 9 +++++++++ | ||
| gradle.properties | 2 +- | ||
| 2 files changed, 10 insertions(+), 1 deletion(-) | ||
|
|
||
| diff --git a/CHANGELOG.md b/CHANGELOG.md | ||
| index 7b2cb23..a1ee761 100644 | ||
| --- a/CHANGELOG.md | ||
| +++ b/CHANGELOG.md | ||
| @@ -3,6 +3,15 @@ | ||
|
|
||
| Changelog of Violations lib. | ||
|
|
||
| +## 1.127 | ||
| +### GitHub [#95](https://github.com/tomasbjerre/violations-lib/issues/95) Add support for "suggested change" *enhancement* | ||
| + | ||
| +**Moving PatchParser from violation-comments-lib** | ||
| + | ||
| + | ||
| +[5c52a3933792d14](https://github.com/tomasbjerre/violations-lib/commit/5c52a3933792d14) Tomas Bjerre *2020-09-06 05:24:56* | ||
| + | ||
| + | ||
| ## 1.126 | ||
| ### GitHub [#95](https://github.com/tomasbjerre/violations-lib/issues/95) Add support for "suggested change" *enhancement* | ||
|
|
||
| diff --git a/gradle.properties b/gradle.properties | ||
| index aca4c1a..eda4430 100644 | ||
| --- a/gradle.properties | ||
| +++ b/gradle.properties | ||
| @@ -1 +1 @@ | ||
| -version = 1.127 | ||
| +version = 1.128-SNAPSHOT | ||
| -- | ||
| 2.25.1 | ||
|
|