Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answer: 54 - Convert pipe and observables to signals - 1 #1177

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DzoeL123
Copy link

@DzoeL123 DzoeL123 commented Jan 20, 2025

Changes:

  • feat: updated currency.service.ts methods and variables to use signals
  • feat: updated transform methods to return price as string
  • feat: removed unwanted use of async pipe in product-row.component.ts

Checklist for challenge submission

  • Start your PR message with Answer:${challenge_number}

Warning:

  • If you want feedback or review, you must support the project on GitHub:

Alternatively, you can still submit your PR to join the list of answered challenges or to be reviewed by a community member. 🔥

@github-actions github-actions bot added 54 big signal cd performance answer answer labels Jan 20, 2025
@tomalaforge tomalaforge added the sponsor sponsor the project label Jan 29, 2025
@tomalaforge
Copy link
Owner

Nice work, but it seems that version 19 is better with signal timing.
Your solution will not work in Angular v18 😅, so that's a bit improvement on the Angular side.

To go a bit further, you could also refactor the @Input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
54 big signal cd performance answer answer sponsor sponsor the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants